1938652 - [wpt-sync] Sync PR 49805 - layout: Implement keyword sizes for block layout heuristics

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49805 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49805
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

layout: Implement keyword sizes for block layout heuristics

<!-- Please describe your changes on the following line: -->
Block layout uses some heuristics to guess whether margins are separated by clearance and then don't collapse. These heuristics now take the min-content, max-content, fit-content and stretch sizing keywords into account.

Reviewed in servo/servo#34695

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad720d8dee6c2b959bf9d1feda02ed0a69023aa9

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

PASS: 4

Safari

PASS: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-001.html [wpt.fyi]: FAIL
• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-002.html [wpt.fyi]: FAIL
• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-003.html [wpt.fyi]: FAIL
• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-004.html [wpt.fyi]: FAIL

New Tests That Don't Pass

• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-001.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: PASS)
• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-002.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: PASS)
• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-003.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: PASS)
• /css/css-sizing/float-clearance-with-margin-collapse-and-fit-content-and-padding-percentage-004.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c704523b920
[wpt PR 49805] - layout: Implement keyword sizes for block layout heuristics, a=testonly
https://hg.mozilla.org/integration/autoland/rev/71693c35d3e2
[wpt PR 49805] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/4c704523b920
https://hg.mozilla.org/mozilla-central/rev/71693c35d3e2