Closed Bug 1938862 Opened 3 months ago Closed 2 months ago

Make `EditorBase::InsertBRElement` to stop duplicating same code

Categories

(Core :: DOM: Editor, task)

Product:
Core
Component:
DOM: Editor
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(1 file)

Bug 1938862 - Create `EditorBase::InsertBRElement` r=m_kato!
48 bytes, text/x-phabricator-request
Details | Review

HTMLEditor needs the following steps when inserting a padding <br>:

  1. Create an HTMLBRElement
  2. Update its stype
  3. Insert the <br> element
  4. Compute the point before the padding <br> to put caret

EditorBase should have a method to do this.

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/2b5d9fe3563a Create `EditorBase::InsertBRElement` r=m_kato

https://hg.mozilla.org/mozilla-central/rev/2b5d9fe3563a

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: