Closed Bug 1938931 Opened 11 months ago Closed 8 months ago

Switch to using JSON file format for storing away messages for cZ

Categories

(SeaMonkey :: Chat, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Future
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.21)

Attachments

(1 file)

At the moment an array of away messages is stored in awayMsgs.txt. Using the JSON format would be a more efficient way of saving an array to a file. Whilst here, remove the now unused serialize method from TextSerializer.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9444964 - Flags: review?(frgrahl)
Attachment #9444964 - Flags: approval-comm-release?

Comment on attachment 9444964 [details] [diff] [review]
1938931-irc-awayMsgs-25321.patch

lgtm r/a+

Nit might have been better to do the migration in a seperate step but not a big mess and can be removed later after a few releases.

Attachment #9444964 - Flags: review?(frgrahl)
Attachment #9444964 - Flags: review+
Attachment #9444964 - Flags: approval-comm-release?
Attachment #9444964 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/d66aec9839b9
Switch to using JSON file format for storing away messages for cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/0888301b11cab3ac46aedb8677bfbe69d91fe365
Switch to using JSON file format for storing away messages for cZ. r=frg a=frg

Whiteboard: SM2.53.21
Target Milestone: --- → Future
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: