Closed
Bug 1938933
Opened 6 months ago
Closed 3 months ago
Switch from deprecated escape/unescape in cZ
Categories
(SeaMonkey :: Chat, task)
SeaMonkey
Chat
Tracking
(seamonkey2.53? affected)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file)
|
3.35 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment cZ makes use of escape and unescape which have been deprecated so should use encodeURIComponent and decodeURIComponent instead.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
Attachment #9444965 -
Flags: review?(frgrahl)
Attachment #9444965 -
Flags: approval-comm-release?
|
||
Updated•3 months ago
|
|
|
||
Comment 2•3 months ago
|
||
Comment on attachment 9444965 [details] [diff] [review]
1938933-irc-escape-unescape-25321.patch
lgtm r/a+
Should const be used delaring the for loop variable? item seems not to change in the loop. But not important.
Attachment #9444965 -
Flags: review?(frgrahl)
Attachment #9444965 -
Flags: review+
Attachment #9444965 -
Flags: approval-comm-release?
Attachment #9444965 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/21962fb0b384
Switch from deprecated escape/unescape in cZ. r=frg DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•