1938933 - Switch from deprecated escape/unescape in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

At the moment cZ makes use of escape and unescape which have been deprecated so should use encodeURIComponent and decodeURIComponent instead.

Comment 1

[Ian Neal]

Attachment: 1938933-irc-escape-unescape-25321.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9444965 [details] [diff] [review]
1938933-irc-escape-unescape-25321.patch

lgtm r/a+

Should const be used delaring the for loop variable? item seems not to change in the loop. But not important.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/21962fb0b384
Switch from deprecated escape/unescape in cZ. r=frg DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/5235d48d7cccc2b8264f9b5c616d740b6ce64862
Switch from deprecated escape/unescape in cZ. r=frg a=frg