Closed Bug 1938937 Opened 11 months ago Closed 8 months ago

Make use of pref fallbacks in pref-manager in cZ

Categories

(SeaMonkey :: Chat, task)

Product:
SeaMonkey
Component:
Chat
Type:
task

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
Future
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.21)

Attachments

(1 file)

1938937-irc-pref-defaults-25321.patch
2.38 KB, patch
frg
: review+
frg
: approval-comm-release+
Details | Diff | Splinter Review

Make use of fallback value when getting prefs in pref-manager rather than using try/catch.

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Attachment #9444967 - Flags: review?(frgrahl)
Attachment #9444967 - Flags: approval-comm-release?
status-seamonkey2.53: --- → affected
tracking-seamonkey2.53: --- → ?
Whiteboard: SM2.53.21

Comment on attachment 9444967 [details] [diff] [review]
1938937-irc-pref-defaults-25321.patch

lgtm r/a+

Attachment #9444967 - Flags: review?(frgrahl)
Attachment #9444967 - Flags: review+
Attachment #9444967 - Flags: approval-comm-release?
Attachment #9444967 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6b1860b23eff
Make use of pref fallbacks in pref-manager in cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: