1939158 - [wpt-sync] Sync PR 49845 - [layout] Fix dirty bits for container queries.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49845 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49845
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[layout] Fix dirty bits for container queries.

container-queries mean that we can invalidate layout within layout.

The logic within MarkParentForSpannerOrOutOfFlowPositionedChange
basically wants to invalidate the parents container chain, however it
wasn't quite doing that.

Instead it was invaliding everything between itself, and its
containing block.

This can differ when we have something like a position:absolute. E.g.
previously we invalidated everything, now we invalidate:

ICB *
html
abspos *
parent *
fixedpos

skipping the "html" element.

This caused the html element to have dirty bits set, even though it
had the correct layout.

Fixed: 385317081
Change-Id: I6621104ea636533f2328a7ca1eb18ff2d895c8b7

Reviewed-on: https://chromium-review.googlesource.com/6120747
WPT-Export-Revision: 935f80c472238b4cc9eb38ce22b91707b1322d58

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a71156759e0b121d97ebed863c3b647d526f6a7d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7671514ca55c
[wpt PR 49845] - [layout] Fix dirty bits for container queries., a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7671514ca55c