1939193 - [wpt-sync] Sync PR 49847 - Refactor OptionListIterator and OptionList, and related code

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49847 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49847
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Refactor OptionListIterator and OptionList, and related code

This CL should not change functionality. It refactors the
OptionList and OptionListIterator classes in a few ways:

• use references rather than pointers in many places, in particular
  *option_list_iterator is now the option, not a pointer to the
  option.
• OptionListIterator's constructor now has an enum to control where
  to start the iteration, which will become more useful with the
  next CL.
• add OptionList::size()

This CL also refactors HTMLOptionElement::DefaultEventHandlerInternal,
using the changes above, plus a new OptionList::NextMatchingOption()
which facilitates iterating the options subject to matching
conditions (like IsFocusable()). This will again get more use in
the following CLs.

Bug: 382101095
Change-Id: Ifb128afca845d8821bd5b45d09706356e62fc083
Reviewed-on: https://chromium-review.googlesource.com/6112153
WPT-Export-Revision: 781d3bbc0af2a4d4f31df1b8b24304a0e7b66cb1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=00670fcc86f77c0000802879ae1052c566e46cab

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/select-keyboard-focus-change-for-hidden-options.tentative.html [wpt.fyi]
  • Hidden options should be skipped when changing focus using the up and down keys.: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aedf04fd49c
[wpt PR 49847] - Refactor OptionListIterator and OptionList, and related code, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6aedf04fd49c