1939499 - LoadSourceMarker is broken due to a field called "type"

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Markus Stange [:mstange]]

I noticed that the LoadSourceMarker which was added in bug 1919123 is mostly non-functional.

Example profile: https://share.firefox.dev/3BERXER

The tooltip for the mozloadresource markers doesn't show the src, media and type fields.

That's because the profiler reserves data.type to identify which schema the marker uses. But this marker has its own type field, which it populates with the video source's mime type. This overwrites the marker type and confuses the profiler front-end.

https://searchfox.org/mozilla-central/rev/222add4dd36e034fa4d0a8b3e4e1ded979599892/dom/media/utils/MediaProfilerMarkers.h#182

{"type", MS::InputType::String, "Type", MS::Format::String},

I recommend renaming this field to mimeType or sourceType.

(On the profiler side, we should change the data representation so that there aren't any reserved field names. This is tracked in issue #4494.)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1919123

:alwu, since you are the author of the regressor, bug 1919123, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1939499 - rename the attribute for LoadSourceMarker.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76167ad914ce
rename the attribute for LoadSourceMarker. r=media-playback-reviewers,chunmin

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/76167ad914ce

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:alwu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.