1939552 - "show content scripts" option breaks devtools when opened on a moz-extension page

Status: RESOLVED DUPLICATE of bug 1941006

(DevTools :: Debugger, defect)

Description

[Denis Lisov]

Steps to reproduce:

1. Start Firefox (Nightly in my case) in a new profile
2. Install an addon with an addon page like https://addons.mozilla.org/en-US/firefox/addon/brief/
3. Open the addon page (for Brief, click the extension button in the extensions toolbar icon menu)
4. Open devtools (F12) - debugger - enable "Show content scripts" in the sources pane gear icon menu
5. Close devtools (F12) and try to open them again (F12)

The devtools panel opens without any content, and the browser console contains the following errors

Failed to sendQuery in DevToolsProcessParent DevToolsProcessParent:watchTargets DevToolsProcessParent.sys.mjs:352:19
    sendQuery resource://devtools/server/connectors/js-process-actor/DevToolsProcessParent.sys.mjs:352
TypeError: can't access property "browser-id", metadata is undefined DevToolsProcessParent.sys.mjs:353:19
    sendQuery resource://devtools/server/connectors/js-process-actor/DevToolsProcessParent.sys.mjs:353
Error while calling actor 'watcher's method 'watchTargets' can't access property "browser-id", metadata is undefined Actor.js:103:13
    writeError resource://devtools/shared/protocol/Actor.js:103
    handler resource://devtools/shared/protocol/Actor.js:242
TypeError: can't access property "browser-id", metadata is undefined
    createTargetsForWatcher resource://devtools/server/connectors/js-process-actor/target-watchers/content_script.sys.mjs:134
    #watchNewTargetTypeForWatcher resource://devtools/server/connectors/js-process-actor/DevToolsProcessChild.sys.mjs:203
    receiveMessage resource://devtools/server/connectors/js-process-actor/DevToolsProcessChild.sys.mjs:306
Actor.js:110:15
    writeError resource://devtools/shared/protocol/Actor.js:110
    handler resource://devtools/shared/protocol/Actor.js:242
Exception while opening the toolbox Error: Protocol error (TypeError): can't access property "browser-id", metadata is undefined from: server0.conn3.watcher3 (resource://devtools/server/connectors/js-process-actor/target-watchers/content_script.sys.mjs:134:9) Error: Protocol error (TypeError): can't access property "browser-id", metadata is undefined from: server0.conn3.watcher3 (resource://devtools/server/connectors/js-process-actor/target-watchers/content_script.sys.mjs:134:9)
    onPacket resource://devtools/shared/protocol/Front.js:382
    DevTools RDP*request resource://devtools/shared/protocol/Front.js:299
    name resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:47
    startListening resource://devtools/shared/commands/target/target-command.js:533
toolbox.js:1146:17
    open resource://devtools/client/framework/toolbox.js:1146

After this happens once, trying to open devtools in any tab on any page results in the same errors and blank pane until browser restart (or disabling devtools.debugger.show-content-scripts in about:config).

Mozregression provides the following regression window containing bugs 1413872 and 1935025
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3d2f56787019df5c7da4e2de884bf5930ccd2755&tochange=1c4f52b8ff322dd7d2a76d4008f4793f3f57d73e

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Based on comment #0, this bug contains a bisection range found by mozregression. However, the Regressed by field is still not filled.

:ochameau, since you are the author of the changes in the range, if possible, could you fill the Regressed by field and investigate this regression?

For more information, please visit BugBot documentation.

Comment 2

[Alexandre Poirot [:ochameau]]

Thanks a lot for your report Denis, sorry I missed your first investigation.
This issue should be fixed via bug 1941006.

Comment 3

[Alexandre Poirot [:ochameau]]

Hi Denis, could you confirm that everything works for you now?
It should be fixed in Firefox Nightly and next Firefox Beta (build > 2025-01-22).

Comment 4

[Denis Lisov]

Seems to be working correctly, thanks!