Closed Bug 193977 Opened 22 years ago Closed 19 years ago

Remove boxes from chatzilla

Categories

(Other Applications :: ChatZilla, enhancement)

Product:
Other Applications
Component:
ChatZilla
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

(Whiteboard: [cz-patch][cz-0.9.68][cz-0.9.69])

Attachments

(2 files, 1 obsolete file)

Updated patch with the extra lines kept in
2.40 KB, patch
samuel
: review+
asa
: approval1.8b2+
Details | Diff | Splinter Review
Patch
1.48 KB, patch
bugzilla-mozilla-20000923
: review+
asa
: approval1.8b3+
Details | Diff | Splinter Review
This is harmless but improves consistency and allows for some userChrome.css magic to apply consistently.
Attached patch basic patch (obsolete) — — Splinter Review
there's a lot of whitespace changes that i could make but that's up to rginda...
Comment on attachment 114860 [details] [diff] [review] basic patch i ran with these changes using the xpi from the website, it worked fine.
Attachment #114860 - Flags: review?(rginda)
Comment on attachment 114860 [details] [diff] [review] basic patch Why did you take out the extra lines?
Product: Core → Other Applications
I updated the patch, since some other changes to the file made it fail anyway. Leaving the extra lines in this time. Requesting review from Samuel.
Attachment #114860 - Attachment is obsolete: true
Attachment #177584 - Flags: review?(samuel)
OS: Windows 2000 → All
Hardware: PC → All
Attachment #114860 - Flags: review?(rginda)
Attachment #177584 - Flags: review?(samuel) → review+
Whiteboard: cz-patch
Attachment #177584 - Flags: approval1.8b2?
Comment on attachment 177584 [details] [diff] [review] Updated patch with the extra lines kept in a=asa
Attachment #177584 - Flags: approval1.8b2? → approval1.8b2+
Checked in --> FIXED. Automated builds at http://twpol.dyndns.org/mozilla/chatzilla/nightly/ will include this shortly.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Reopening. This patch causes the tabs to move along when you use the grippy that comes with the multiline input box. Apparently, this was the reason the extra boxes were in there. Silver said: [quote] The tabpanels-contents-box and tabstrip-box need to be children of a sibling to input-splitter. Currently they're all siblings. [end-quote] So, I'm asking for the patch to be backed out, after which (I think) this bug would be marked invalid (not a bug).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We don't need to back this out - only add back one of the boxes.
Attached patch Patch — — Splinter Review
Puts back in one of the boxes. Note that the line of whitespace I'm adding was removed in the previous patch, since it was redundant at that time (two lines where only one was logical / necessary). I'm simply backing up that removal.
Attachment #185060 - Flags: review?(silver)
Comment on attachment 185060 [details] [diff] [review] Patch r=silver
Attachment #185060 - Flags: review?(silver)
Attachment #185060 - Flags: review+
Attachment #185060 - Flags: approval1.8b3?
Attachment #185060 - Flags: approval1.8b3? → approval1.8b3+
Checked in --> RE-FIXED.
Status: REOPENED → RESOLVED
Closed: 20 years ago → 19 years ago
Resolution: --- → FIXED
Whiteboard: cz-patch → [cz-patch][cz-0.9.68]
Whiteboard: [cz-patch][cz-0.9.68] → [cz-patch][cz-0.9.68][cz-0.9.69]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: