Closed Bug 1939795 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 49895 - Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49895 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49895
Details from upstream follow.

Tim Sergeant <tsergeant@chromium.org> wrote:

Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet"

This reverts commit f0cab8e2346b2a62aa3be1d5a41ec7737bf335af.

Reason for revert: New tests are failing on linux-chromeos-dbg:

https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-dbg/38480/test-results

Original change's description:

[shared storage] Implement sharedStorage.batchUpdate() for PA worklet

Add sharedStorage.batchUpdate() function. Parse arguments into
the 'methods' sequence and a 'with_lock' optional flag, and
propagate the result to the browser process to invoke the
SharedStorageLockManager::SharedStorageBatchUpdate() API.

This allows developers to perform multiple Shared Storage operations atomically within a single lock, as part of the Web
Lock integration proposal:

Fuchsia-Binary-Size: Size increase is unavoidable.
Bug: 373899210
Change-Id: Ic6e9f794d78523ec9f6b87f37fb5e91f17635c58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6072850
Commit-Queue: Yao Xiao \<yaoxia@chromium.org>
Reviewed-by: Maks Orlovich \<morlovich@chromium.org>
Reviewed-by: Cammie Smith Barnes \<cammie@chromium.org>
Reviewed-by: Giovanni Ortuno Urquidi \<ortuno@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401673}

Bug: 373899210
Change-Id: I46c27d924dae0684a07ec081095d8dbde970b6ca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6123546
Owners-Override: Tim Sergeant \<tsergeant@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Tim Sergeant \<tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401696}

PR 49895 applied with additional changes from upstream: 078605da614507d4428c3cc92040ad750959018f
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6cd08500ad8b [wpt PR 49895] - Revert "[shared storage] Implement sharedStorage.batchUpdate() for PA worklet", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.