1939863 - [wpt-sync] Sync PR 49897 - [attr] Look up attribute by local-name and null-namespace

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49897 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49897
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[attr] Look up attribute by local-name and null-namespace

When the namespace part of the \<attr-name> is omitted, it defaults
to the null-namespace. We currently implement this with Element::
getAttribute, which gives the wrong result, since it returns
the first attribute with the given qualified name [1].

Note: the lookup is now effectively the same as what "old"
(non-substitution) attr() did.

[1] https://dom.spec.whatwg.org/#concept-element-attributes-get-by-name

Issue: 387281256
Change-Id: If42dbe210402b95f03c3d7419c161970b6c3f612
Reviewed-on: https://chromium-review.googlesource.com/6140914
WPT-Export-Revision: 7e1f8378ec205b4f479a4dffe92be69575ea27e8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3ab35b83560bb4170fc922d9fc1efbdeb2359285

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 4

Chrome

OK : 1
PASS: 3
FAIL: 2

Safari

OK : 1
PASS: 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/attr-null-namespace.xhtml [wpt.fyi]
  • Attribute in null-namespace is substituted: FAIL (Chrome: PASS, Safari: FAIL)
  • Fallback is taken when attribute does not exist in null-namespace: FAIL (Chrome: PASS, Safari: FAIL)
  • Attribute in null-namespace is substituted (JS): FAIL (Chrome: FAIL, Safari: FAIL)
  • Fallback is taken when attribute does not does exist in null-namespace (JS): FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00871638b077
[wpt PR 49897] - [attr] Look up attribute by local-name and null-namespace, a=testonly
https://hg.mozilla.org/integration/autoland/rev/8bdb69b0ffea
[wpt PR 49897] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/00871638b077
https://hg.mozilla.org/mozilla-central/rev/8bdb69b0ffea