1939908 - [wpt-sync] Sync PR 49907 - Reapply "IDB: direct reads for blobs"

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49907 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49907
Details from upstream follow.

Evan Stade <[e-mail]> wrote:

Reapply "IDB: direct reads for blobs"

This relands commit 60632268eadd3051d4ec88d62292b160682f8a56.

Difference to original: added support for AsDataPipeGetter and
extended blob-contenttype.any.js WPT to cover this case.

Original change's description:

IDB: direct reads for blobs

For the standard case of a page reading IDB data from the blob store,
don't go through the blob registry on the i/o thread and instead
connect the IDB bucket thread directly to the renderer.

In some other (rarer) cases the blob registry is still used. This
is accomplished by additionally registering a blob with
BlobStorageContext using the same UUID, which is necessary for:

• WriteBlobToFile(), which does lookup by UUID
• loading data for a blob:// URL, i.e. mojom::Blob::Load, which is
  thunked through to the registry blob because implementation is non-
  trivial

Bug: 373684390
Change-Id: I9235f23303e4e6a05bf12a8acff32a5fb4e2a565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6113789
Commit-Queue: Evan Stade \<[e-mail]>
Reviewed-by: Steve Becker \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1400627}

Bug: 373684390
Change-Id: Ie555cf4b583b862d306c43e3e4be76e957ea6c5a

Reviewed-on: https://chromium-review.googlesource.com/6138579
WPT-Export-Revision: 7f9b8bc1a4aef4d74aab98827395201e11ecde7f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9861313c1b3e6afbb794d38ef85cc1dc554c8ffe

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
PASS: 2

Chrome

OK : 2
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c7f38e11aac
[wpt PR 49907] - Reapply "IDB: direct reads for blobs", a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5c7f38e11aac