Closed
Bug 1939918
Opened 2 months ago
Closed 2 months ago
Remove `newtab/test/unit/utils` dependancy in aboutwelcome and asrouter karma unit tests
Categories
(Firefox :: Messaging System, task, P2)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: pdahiya, Assigned: pdahiya)
References
(Blocks 1 open bug)
Details
(Whiteboard: [hnt-trainhop] )
Attachments
(1 file)
Scope of this bug is to remove aboutwelcome and asrouter karma unit tests dependency on newtb/test/unit/utils.js
It's currently used in below messaging system karma tests
https://searchfox.org/mozilla-central/search?q=newtab%2Ftest&path=aboutwelcome&case=false®exp=false
https://searchfox.org/mozilla-central/search?q=test%2Funit%2Futils&path=asrouter&case=false®exp=false
This can be done by creating utils.js under asrouter/tests/unit/utils.js with only functions needed by messaging system karma tests
|
Assignee | |
Updated•2 months ago
|
Whiteboard: [hnt-trainhop]
|
||
Updated•2 months ago
|
|
|
Assignee | |
Updated•2 months ago
|
Priority: -- → P2
|
|
Assignee | |
Updated•2 months ago
|
Assignee: nobody → pdahiya
Iteration: --- → 136.1 - Jan 6 - Jan 17
|
|
Assignee | |
Comment 1•2 months ago
|
||
Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95ad59c29198
Remove newtab utils dependancy in aboutwelcome and asrouter karma unit tests r=omc-reviewers,mconley,emcminn
|
|
Assignee | |
Updated•2 months ago
|
Points: --- → 3
|
||
Comment 3•2 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•