[wpt-sync] Sync PR 49911 - Ensure Element ID modifications inside disconnected shadow roots are registered
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox136 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 49911 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/49911
Details from upstream follow.
Simon Wülker <simon.wuelker@arcor.de> wrote:
Ensure Element ID modifications inside disconnected shadow roots are registered
The previous code used
Node::is_connectedinstead ofNode::is_tree_connected, meaning that modifications to an element id inside a shadow root that is not connected to a document would not be registered.Also fixes a crash with registering named elements caused by the same problem. Both of these changes are covered by the new web platform test.
We'll likely run into more of these issues as we integrate the shadow dom into the codebase.
Reviewed in servo/servo#34834
|
Assignee | |
Updated•2 months ago
|
|
|
Assignee | |
Comment 1•2 months ago
|
||
|
|
Assignee | |
Comment 2•2 months ago
|
||
|
|
Assignee | |
Comment 3•2 months ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS: 1
Chrome
OK : 1
PASS: 1
Safari
OK : 1
PASS: 1
Description
•