Open Bug 1939949 Opened 1 year ago Updated 1 year ago

https://github.com/openai/procgen is 2.1x slower in Nightly (slowness in array_concat)

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

People

(Reporter: mayankleoboy1, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

Go to https://github.com/openai/procgen
Scroll down to where the GIF will play or the graphs will appear
Try to select some text on the page

Chrome: https://share.firefox.dev/401Rncj (10s)
Nightly: https://share.firefox.dev/403ZlSd (21s)

We do use the fast path for concat on packed arrays, but there's a lot of background freeing happening too. Worth retesting after bug 1911537.

Depends on: 1911537

Now that the slots and elements allocator has landed, is this in better shape?

Severity: -- → S3
Flags: needinfo?(mayankleoboy1)
Priority: -- → P3

I am guessing it would also need bug 1934856 before the buffer is actually used?
Profile: https://share.firefox.dev/400pSQm

This is what i get on latest Nightly: https://share.firefox.dev/422iczB

Flags: needinfo?(mayankleoboy1)

Latest profile: https://share.firefox.dev/3PMxyRn

You need to log in before you can comment on or make changes to this bug.