1939965 - Make use of toSOutputStream and toSInputStream helpers in DCC code in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

We have toSOutputStream and toSInputStream helpers so might as well make use of them in the DCC code.
Whilst here, remove the redundant argument from CBSConnection calls.

Comment 1

[Ian Neal]

Attachment: 1939965-irc-dcc-cbs-25321.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9445776 [details] [diff] [review]
1939965-irc-dcc-cbs-25321.patch

LGTM. r/a+ Tossing a coin if I should add a second sublect line with the drive by fix mentioned for check-in.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3ee32dfae7af
Make use of toSOutputStream and toSInputStream helpers in DCC code in cZ. r=frg DONTBUILD

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/7cdcd3c781b1178e687b95ae1acb8ec561970f48
Make use of toSOutputStream and toSInputStream helpers in DCC code in cZ. r=frg a=frg