Stop hard-coding commandkey for reloadui in cZ
Categories
(SeaMonkey :: Chat, defect)
Tracking
(seamonkey2.53+ fixed)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.21)
Attachments
(1 file)
|
2.01 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment the commandkey for reloadui in cZ is hard-coded to R, this should be localisable as it is for reload in browser/mailnews.
Whilst here remove redundant check for existence of the function and non-standard format for the modifiers (comma is usually used instead of space as a separator).
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: one new entity
Updated•1 year ago
|
Comment 2•1 year ago
|
||
Comment on attachment 9445777 [details] [diff] [review]
1939968-irc-key-reloadui-25321.patch
LGTM r/a+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9fed99cc55ca
Stop hard-coding commandkey for reloadui in cZ. r=frg DONTBUILD
Comment 4•1 year ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/870d865db628d05724618a0634fd0412167be022
Stop hard-coding commandkey for reloadui in cZ. r=frg a=frg
Description
•