Closed Bug 1939968 Opened 1 year ago Closed 1 year ago

Stop hard-coding commandkey for reloadui in cZ

Categories

(SeaMonkey :: Chat, defect)

defect

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
Future
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.21)

Attachments

(1 file)

At the moment the commandkey for reloadui in cZ is hard-coded to R, this should be localisable as it is for reload in browser/mailnews.
Whilst here remove redundant check for existence of the function and non-standard format for the modifiers (comma is usually used instead of space as a separator).

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.21pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: one new entity

Attachment #9445777 - Flags: review?(frgrahl)
Attachment #9445777 - Flags: approval-comm-release?
Whiteboard: SM2.53.21

Comment on attachment 9445777 [details] [diff] [review]
1939968-irc-key-reloadui-25321.patch

LGTM r/a+

Attachment #9445777 - Flags: review?(frgrahl)
Attachment #9445777 - Flags: review+
Attachment #9445777 - Flags: approval-comm-release?
Attachment #9445777 - Flags: approval-comm-release+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9fed99cc55ca
Stop hard-coding commandkey for reloadui in cZ. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: