1940009 - Unit pt missing from Fonts tab in developer tools

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Ambrose Li]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

1. Open Developer Tools
2. Go to the Fonts tab
3. Try to change unit to pt

Actual results:

pt is not in the dropdown

Expected results:

pt should be in the dropdown. In fact, any unit that’s appeared in any CSS actually used by the page (e.g., mm, if mm appears in any loaded CSS file) should be in the dropdown.

I do print-based layouts and I use only pt (px is meaningless for print). The current output for the Fonts tab is not useful for people who try to work on / debug layouts that target print.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

the list of units is defined in https://searchfox.org/mozilla-release/rev/d8f30fc43d8a411937b53bb95eb9555356e9bcb8/devtools/client/inspector/fonts/components/FontSize.js#81

unitOptions: ["em", "rem", "%", "px", "vh", "vw"],

It shouldn't be too hard to add a pt item there.

Comment 3

[Meike [:mei]]

Hi all, I would like to work on this bug

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Helo Meike, the bug is now yours :)
If you didn't already, going over https://firefox-source-docs.mozilla.org/devtools/index.html might help you to write a patch and submit it for review.
Let us know if you have any question on this!

Comment 5

[Meike [:mei]]

Attachment: Bug 1940009 - Add pt to size unit options in FontSize component. r?nchevobbe

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864970c4b199
Add pt to size unit options in FontSize component. r=nchevobbe,devtools-reviewers

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/864970c4b199