1940030 - Glean: Duplicate metric identifiers detected: broken_site_report.*

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean Platform, defect, P1)

Description

[Jan-Erik Rediger [:janerik]]

With the addition from bug 1925088, which has the same metrics from the webcompat report as implementedin Gecko, now exposed to Fenix, we're getting a whole bunch of dupe detections.

We will have to mitigate this in probe-scraper.
Or moving the metrics in m-c from a Gecko file into a ffx-desktop file.

Full list as per the email:

broken_site_report.breakage_category
broken_site_report.description
broken_site_report.url
broken_site_report.browser_info.app.default_locales
broken_site_report.browser_info.app.default_useragent_string
broken_site_report.browser_info.app.fission_enabled
broken_site_report.browser_info.graphics.device_pixel_ratio
broken_site_report.browser_info.graphics.devices_json
broken_site_report.browser_info.graphics.drivers_json
broken_site_report.browser_info.graphics.features_json
broken_site_report.browser_info.graphics.has_touch_screen
broken_site_report.browser_info.graphics.monitors_json
broken_site_report.browser_info.prefs.cookie_behavior
broken_site_report.browser_info.prefs.global_privacy_control_enabled
broken_site_report.browser_info.prefs.installtrigger_enabled
broken_site_report.browser_info.prefs.opaque_response_blocking
broken_site_report.browser_info.prefs.resist_fingerprinting_enabled
broken_site_report.browser_info.prefs.software_webrender
broken_site_report.browser_info.system.memory
broken_site_report.tab_info.languages
broken_site_report.tab_info.useragent_string
broken_site_report.tab_info.antitracking.block_list
broken_site_report.tab_info.antitracking.btp_has_purged_site
broken_site_report.tab_info.antitracking.has_mixed_active_content_blocked
broken_site_report.tab_info.antitracking.has_mixed_display_content_blocked
broken_site_report.tab_info.antitracking.has_tracking_content_blocked
broken_site_report.tab_info.antitracking.is_private_browsing
broken_site_report.tab_info.frameworks.fastclick
broken_site_report.tab_info.frameworks.marfeel
broken_site_report.tab_info.frameworks.mobify

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1940030 - Move reportbrokensite metrics under firefox-desktop r?chutten

As defined and used these are firefox-desktop specific, not Gecko.
Currently this is causing duplicate-definition warnings in the data
pipeline, due to them being redefined in Fenix too.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: [mozilla/probe-scraper] Bug 1940030 - Ignore broken_site_report.* reports for dupe-detection (#849)

Comment 4

[Jan-Erik Rediger [:janerik]]

badboy merged PR [mozilla/probe-scraper]: Bug 1940030 - Ignore broken_site_report.* reports for dupe-detection (#849) in caf3ca2.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b65782fa090
Move reportbrokensite metrics under firefox-desktop r=chutten,twisniewski

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0b65782fa090