1940126 - [wpt-sync] Sync PR 49928 - Prevent closing with tab when in dialog mode

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49928 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49928
Details from upstream follow.

Ana Sollano Kim <[e-mail]> wrote:

Prevent closing with tab when in dialog mode

For customizable select in dialog mode, tab should be used to navigate within the picker and not to close the picker. Tests are added to validate behavior. Note: failure in Mac is slightly different to Linux and Windows, so I had to add that entry to the TestExpectations file.

Bug: 374908738
Change-Id: I0eec89e0d85b2b4d7cb33192b07ea9c2ef43081e

Reviewed-on: https://chromium-review.googlesource.com/6143233
WPT-Export-Revision: f2a4cd40af7e7d9088cdf06fb2df0afb8fcfa729

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 49928 applied with additional changes from upstream: 1b5ba3f9db87a928c1cd1ce002bcf41be6bfd7f2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd6094fe909178bcd955fab7ef02485ef7e9f63b

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/select-dialog-mode-focus.tentative.html [wpt.fyi]
  • In dialog mode the first focusable element should get focus.: FAIL (Chrome: FAIL, Safari: FAIL)
  • In dialog mode tab should not close the picker.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/264683ab0f93
[wpt PR 49928] - Prevent closing with tab when in dialog mode, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f4dfd031ee0d
[wpt PR 49928] - Update wpt metadata, a=testonly

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/264683ab0f93
https://hg.mozilla.org/mozilla-central/rev/f4dfd031ee0d