1940129 - [wpt-sync] Sync PR 49929 - Make dialog focus async when removing open attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49929 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49929
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Make dialog focus async when removing open attribute

When the dialog's open attribute is removed which closes the dialog, we
should make the focus async in order to prevent more script from running
inside attribute removal.

Context: https://github.com/whatwg/html/pull/10124#discussion_r1483640232

Bug: 341935362
Change-Id: I1b76f003e04b802b1868b427a0faddf5f19a3c5e

Reviewed-on: https://chromium-review.googlesource.com/6085725
WPT-Export-Revision: c63d4cf04f5c7529e968dad54cfa502cb305ee9c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e17f51ad5af95e6063d98eafa3d28fd6f14fe5f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/interactive-elements/the-dialog-element/dialog-close-via-attribute.tentative.html [wpt.fyi]
  • Removing the open attribute from an open modal dialog should run the closing algorithm.: FAIL (Chrome: FAIL, Safari: FAIL)
  • Removing the open attribute from an open non-modal dialog should fire a close event.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17e5e580ddfe
[wpt PR 49929] - Make dialog focus async when removing open attribute, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/17e5e580ddfe