Closed Bug 1940175 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 49941 - [A11y] Support spaces in IDs used for aria-activedescendant

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49941 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49941
Details from upstream follow.

Alice Boxhall <alice@igalia.com> wrote:

[A11y] Support spaces in IDs used for aria-activedescendant

Spaces in IDs aren't legal HTML, but authors still use them, and they are supported for some other APIs like getElementById(). Prior to https://crrev.com/c/5836703, they were also able to be used for aria-activedescendant attributes, which only take a single ID, and authors have depended on this behaviour.

This change restores the old functionality, and adds a regression test.

Bug: 382526983
AX-Relnotes: n/a
Change-Id: I3ad56399686d653e4db2ca6076a84e505c70bb4a
Reviewed-on: https://chromium-review.googlesource.com/6133178
WPT-Export-Revision: e0a3a2e15634647abb759736cc707502ae100a19

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
PASS: 6
FAIL: 2

Chrome

OK : 1
PASS: 8

Safari

OK : 1
PASS: 7
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /custom-elements/element-internals-aria-element-reflection.html [wpt.fyi]
    • Setting ariaLabelledByElements on ElementInternals should change the accessible name of the custom element: FAIL (Chrome: PASS, Safari: PASS)
    • Setting aria-labelledby or ariaLabelledByElements on the custom element should supersede the value of ariaLabelledByElements on ElementInternals: FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d912a17e1870 [wpt PR 49941] - [A11y] Support spaces in IDs used for aria-activedescendant, a=testonly https://hg.mozilla.org/integration/autoland/rev/4fbc8239b020 [wpt PR 49941] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d912a17e1870
https://hg.mozilla.org/mozilla-central/rev/4fbc8239b020

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.