1940193 - An exception while handling a CalDAV item stops all subsequent items being processed

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[Geoff Lankow (:darktrojan)]

If, while processing a CalDAV request, an exception is thrown (such as bug 1659076's "foundItem is null") the code will just bubble the exception up and not handle the rest of the request payload, because there is no exception handling. This is madness.

I've filed a separate bug as (a) I'm not convinced it's the solution to all of the other bugs' problems and (b) those bugs have enough comments in them already.

Comment 1

[Geoff Lankow (:darktrojan)]

I tried to write a regression test for this and it's not as bad as I first thought. There's still many things which could potentially fail on one item but shouldn't prevent the other items being processed. But the test I had in mind isn't going to work.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1940193 - Catch and log errors while processing CalDAV item requests. r=#thunderbird-reviewers

An exception thrown handling one item shouldn't prevent the handling of subsequent items.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/940b8f4cc12e
Catch and log errors while processing CalDAV item requests. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9445979 [details]
Bug 1940193 - Catch and log errors while processing CalDAV item requests. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: I'm hoping this fixes reports of calendar events mysteriously disappearing.
Testing completed (on c-c, etc.): Landed on Friday.
Risk to taking this patch (and alternatives if risky): Not risky. This is just a few try/catch blocks.

Comment 5

[Corey Bryant]

Comment on attachment 9445979 [details]
Bug 1940193 - Catch and log errors while processing CalDAV item requests. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 135.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/5aa7f3f76a36

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9445979 [details]
Bug 1940193 - Catch and log errors while processing CalDAV item requests. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: I'm hoping this fixes reports of calendar events mysteriously disappearing.
Testing completed (on c-c, etc.): In 135 beta 2.
Risk to taking this patch (and alternatives if risky): Not risky. This is just a few try/catch blocks.

Comment 8

[Corey Bryant]

Comment on attachment 9445979 [details]
Bug 1940193 - Catch and log errors while processing CalDAV item requests. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 128.7.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/841c9b5d60b2