1940237 - [wpt-sync] Sync PR 49947 - Revert "[Reland] Handle appearance value changes during <select> showPicker."

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49947 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49947
Details from upstream follow.

Danila Kuzmin <[e-mail]> wrote:

Revert "[Reland] Handle appearance value changes during <select> showPicker."

This reverts commit 5fa283f55fea44480ce73308cb12de0274867c1e.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5657193371140096

Sample build with failed test: https://ci.chromium.org/b/8726470617543936881
Affected test(s):
ninja://:blink_wpt_tests/external/wpt/html/semantics/forms/the-select-element/customizable-select/switch-picker-appearance.tentative.html

Original change's description:

[Reland] Handle appearance value changes during \<select> showPicker.

When the appearance value changes as the result of the picker
opening (e.g. via ::picker(select):open {appearance:auto} or
similar), we close the picker to avoid any oscillation or
nonsensical behavior. This CL implements this change.

The original CL [1] was reverted due to a strange bot failure [2]
where the new set of promise_tests somehow fail because
blink_wpt_tests is expecting an expectation file with a single blank
line. I added a "Failure" expectation to hopefully avoid that, in
Patchset 3.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/6094831
[2] https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/50289/overview

Fixed: 376097114,370536090,367426156
Bug: 384394713
Change-Id: I2ab4e43db3de4b7125b564c366fe86bdf9f85cc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6107689
Auto-Submit: Mason Freed \<[e-mail]>
Reviewed-by: Joey Arhar \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Commit-Queue: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1402440}

Bug: 384394713
Change-Id: Ic5392451a1ffe93b40c3a9748164bc03abbfc884
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6148450
Reviewed-by: Bohdan Tyshchenko \<[e-mail]>
Auto-Submit: Danila Kuzmin \<[e-mail]>
Owners-Override: Danila Kuzmin \<[e-mail]>
Commit-Queue: Bohdan Tyshchenko \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1402871}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
PASS: 1
FAIL: 8

Safari

OK : 1
FAIL: 9

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/switch-picker-appearance.tentative.html [wpt.fyi]
  • Basic functionality of select picker and appearance: FAIL (Chrome: PASS, Safari: FAIL)
  • Basic functionality of select picker with appearance:auto: FAIL (Chrome: FAIL, Safari: FAIL)
  • Basic functionality of select picker with appearance:none: FAIL (Chrome: FAIL, Safari: FAIL)
  • Switching appearance in popover-open should close the picker: FAIL (Chrome: FAIL, Safari: FAIL)
  • Switching appearance in JS after picker is open should close the picker: FAIL (Chrome: FAIL, Safari: FAIL)
  • Test of the test harness: FAIL (Chrome: FAIL, Safari: FAIL)
  • The select picker is closed if the <select> appearance value is changed via CSS while the picker is open: FAIL (Chrome: FAIL, Safari: FAIL)
  • The select picker is closed if the ::picker() appearance value is changed via CSS while the picker is open: FAIL (Chrome: FAIL, Safari: FAIL)
  • The select picker is closed if the <select> inline appearance value is changed while the picker is open: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4afed9b74fac
[wpt PR 49947] - Revert "[Reland] Handle appearance value changes during <select> showPicker.", a=testonly

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/4afed9b74fac