1940265 - Offer option to print rather than open phab auth code URL when using mach try pushing to lando

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, enhancement, P3)

Description

[:Gijs (he/him)]

moz-phab version (from moz-phab version): 1.8.1

STR:

1. commit something in m-c
2. ./mach try fuzzy
3. select all the tasks you want
4. accept out of fzf
5. a tab opens in the default browser with the lando auth page for the 8-digit code thingy

Unfortunately, the tab opens in a container inside Firefox that does not have the right cookies for me to auth (and I don't want it to have them).

6. try to reload the page in a different container

This will fail as the codes are one-time-use.

AR:
errors, failure to auth, and the commandline just sits there waiting for auth and has to be ctrl-C'd

ER:
some way to load the URL in an environment that either already has the right session cookie or where it can be created by authenticating.

Per discussion on slack, the easiest solve here might be an option that will only print the URL instead of open it.

Comment 1

[Connor Sheehan [:sheehan]]

(In reply to :Gijs (he/him) from comment #0)

Per discussion on slack, the easiest solve here might be an option that will only print the URL instead of open it.

This seems reasonable to me. I took a quick look and the Python webbrowser module doesn't support containers. I wasn't aware the codes were 1-time use only.

Comment 2

[:glob ✱]

Attachment: Bug 1940265 - Add ability to prevent the automatic url opening during 'mach try' r=sheehan

There's situations where opening the auth0 verification URL in the default
browser is problematic; eg. for those using containers and the default
container isn't one that's use for auth0. As the URLs can only be opened once,
there isn't the opportunity to open the URL in another container/browser/etc.

Add a simple environment var 'LANDO_AUTH_NO_BROWSER' to disable the URL opening
action.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0d2d28816ca4
https://hg.mozilla.org/integration/autoland/rev/16ab8603619c
Add ability to prevent the automatic url opening during 'mach try' r=sheehan

Comment 4

[:glob ✱]

The just-landed fix for this requires adding an option to your machrc file (which may require creating one).
See https://firefox-source-docs.mozilla.org/mach/settings.html and mach settings.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/16ab8603619c