Closed Bug 1940281 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 49953 - [Masonry] Introduce parsing for masonry-flow.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49953 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49953
Details from upstream follow.

Celeste Pan <celestepan@microsoft.com> wrote:

[Masonry] Introduce parsing for masonry-flow.

This CL introduces the parsing for the CSS property masonry-flow, which
is the shorthand for masonry-direction and masonry-fill.

This is part of: https://chromestatus.com/feature/5149560434589696

The properties are behind the CSSMasonryLayout feature flag. The spec
definition for masonry-flow can be found here:
https://tabatkins.github.io/specs/css-masonry/#masonry-flow.

Bug: 343257585
Change-Id: Icaba5964a6b377a13958e404f7f464e933efc209
Reviewed-on: https://chromium-review.googlesource.com/6106736
WPT-Export-Revision: 141f5bf9e13091c2fdc08676e80f9041a040bc9f

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 32 subtests

Status Summary

Firefox

OK : 3
PASS: 7
FAIL: 40

Chrome

OK : 3
PASS: 7
FAIL: 40

Safari

OK : 3
PASS: 7
FAIL: 40

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-masonry/tentative/parsing/masonry-flow-computed.html [wpt.fyi]
    • Property masonry-flow value 'column normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-flow value 'column reverse': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-flow value 'row normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-flow value 'row reverse': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-flow value 'column-reverse normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-flow value 'column-reverse reverse': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-flow value 'row-reverse normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-flow value 'row-reverse reverse': FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-masonry/tentative/parsing/masonry-flow-valid.html [wpt.fyi]
    • e.style['masonry-flow'] = "column normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "column-reverse reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse reverse" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse normal" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse normal" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse normal" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse reverse" should set masonry-direction: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse reverse" should set masonry-fill: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-flow'] = "row-reverse reverse" should not set unrelated longhands: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e34b153b96b3 [wpt PR 49953] - [Masonry] Introduce parsing for masonry-flow., a=testonly https://hg.mozilla.org/integration/autoland/rev/63ed2c8c957e [wpt PR 49953] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e34b153b96b3
https://hg.mozilla.org/mozilla-central/rev/63ed2c8c957e

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.