1940283 - Add a linter to ensure that licenses included via the top-level package.json are acceptable

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

When we ship new node modules, or update our node modules we should be checking that the licenses are (still) acceptable. Generally I've been checking this when I've reviewed the addition of new modules, but I think it would be reasonable to have an automated check for which a linter which would mean we don't have to remember to do it, and we have the list already written.

Currently I'm looking at using license-checker-rseidelsohn, though a couple of packages it requires use a different license (which we haven't checked before) and are obsolete. So I'm going to see if we're able to get that package updated to not use those.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1940283 - Only clear out eslint-plugin-mozilla's node_modules directory when running ESLint set-up. r?#linter-reviewers!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1940283 - Add a node-licenses linter to ensure that licenses included via the top-level and eslint-plugin-mozilla package.json files are acceptable. r?#linter-reviewers!,#releng-reviewers!,#frontend-codestyle-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e9966efeec10
https://hg.mozilla.org/integration/autoland/rev/3a17ceb87e6f
Only clear out eslint-plugin-mozilla's node_modules directory when running ESLint set-up. r=linter-reviewers,sylvestre
https://github.com/mozilla-firefox/firefox/commit/f194594a1e33
https://hg.mozilla.org/integration/autoland/rev/8357f48fa211
Add a node-licenses linter to ensure that licenses included via the top-level and eslint-plugin-mozilla package.json files are acceptable. r=linter-reviewers,releng-reviewers,frontend-codestyle-reviewers,jcristau,ahal,mossop

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3a17ceb87e6f
https://hg.mozilla.org/mozilla-central/rev/8357f48fa211