1940308 - [wpt-sync] Sync PR 49958 - [Reland, x2] Handle appearance value changes during <select> showPicker.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 49958 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49958
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

[Reland, x2] Handle appearance value changes during <select> showPicker.

*** GARDENERS: ***
Please don't revert this CL again. Simply mark the
switch-picker-appearance.tentative.html test as failing in
TestExpectations and that should fix the problem. Thanks!

---

When the appearance value changes as the result of the picker
opening (e.g. via ::picker(select):open {appearance:auto} or
similar), we close the picker to avoid any oscillation or
nonsensical behavior. This CL implements this change.

The original CL [1] was reverted due to a strange bot failure [2]
where the new set of promise_tests somehow fail because
blink_wpt_tests is expecting an expectation file with a single blank
line. I added a "Failure" expectation to hopefully avoid that, in
Patchset 3.

The first reland CL [3] was reverted due to a (fairly serious, in my
opinion) bug [4] in the WPT importer that was missed by the gardener
(it was nuanced) and resulted in this CL getting reverted again.
This re-land includes Timeout as a failure mode for all platforms.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/6094831
[2] https://ci.chromium.org/ui/p/chromium/builders/ci/mac11-arm64-rel-tests/50289/overview
[3] https://chromium-review.googlesource.com/c/chromium/src/+/6107689
[4] https://issues.chromium.org/issues/367426156#comment13

Fixed: 376097114,370536090,367426156
Bug: 384394713
Change-Id: I2d22aa452b071ac9eb259dd4ae4e097b970b8851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6150897
Reviewed-by: Joey Arhar \<[e-mail]>
Auto-Submit: Mason Freed \<[e-mail]>
Commit-Queue: Joey Arhar \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1403101}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=336c622fa7d72183d1ef7b8982d48466d66e3c57

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
PASS: 4
FAIL: 5

Safari

OK : 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/switch-picker-appearance.tentative.html [wpt.fyi]
  • Basic functionality of select picker and appearance: FAIL (Chrome: PASS, Safari: FAIL)
  • Basic functionality of select picker with appearance:auto: FAIL (Chrome: PASS, Safari: FAIL)
  • Basic functionality of select picker with appearance:none: FAIL (Chrome: PASS, Safari: FAIL)
  • Switching appearance in popover-open should close the picker: FAIL (Chrome: FAIL, Safari: FAIL)
  • Switching appearance in JS after picker is open should close the picker: FAIL (Chrome: PASS, Safari: FAIL)
  • Test of the test harness: FAIL (Chrome: FAIL, Safari: FAIL)
  • The select picker is closed if the <select> appearance value is changed via CSS while the picker is open: FAIL (Chrome: FAIL, Safari: FAIL)
  • The select picker is closed if the ::picker() appearance value is changed via CSS while the picker is open: FAIL (Chrome: FAIL, Safari: FAIL)
  • The select picker is closed if the <select> inline appearance value is changed while the picker is open: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/405a3f3e7c1a
[wpt PR 49958] - [Reland, x2] Handle appearance value changes during <select> showPicker., a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/405a3f3e7c1a