Closed Bug 1940325 Opened 1 month ago Closed 22 days ago

Build failure with ICU 73.x

Categories

(Core :: Internationalization, defect)

Firefox 134
defect

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: jpalus+mozilla, Assigned: anba)

Details

Attachments

(1 file)

Steps to reproduce:

Build Firefox 134.0 with system ICU 73.2.

Actual results:

Build failed on static assertion:

firefox-134.0/intl/lwbrk/LineBreaker.cpp:461:17: error: static assertion failed due to requirement 'U_LB_COUNT == std::size(sUnicodeLineBreakToClass)': Gecko vs ICU LineBreak class mismatch

Expected results:

Build should fail at configure time or succeed.


When building Firefox with system ICU it still requires ICU >= 73.1:

https://searchfox.org/mozilla-central/rev/e24277e20c492b4a785b4488af02cca062ec7c2c/js/moz.configure#1304

However to satisfy static assertion:

https://searchfox.org/mozilla-central/rev/e24277e20c492b4a785b4488af02cca062ec7c2c/intl/lwbrk/LineBreaker.cpp#461

It needs following upstream commit:

https://github.com/unicode-org/icu/commit/2e45e6ec0e84a1c01812015a254ea31b286316fb

Effectively requiring ICU >= 74.1

Assignee: nobody → andrebargull
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8f62091234e5 Update minimum required system ICU version to 76.1. r=platform-i18n-reviewers,nordzilla
Status: ASSIGNED → RESOLVED
Closed: 22 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: