1940367 - Fix cases where stretch-block-size-003.html inadvertently has a 0-size parent

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Daniel Holbert [:dholbert]]

IanK alerted me to some pieces of this test (added in bug 1937624) that are failing in Chrome, where the test's expectations are probably incorrect:
https://wpt.live/css/css-sizing/stretch/stretch-block-size-003.html

I think the same is true for this test:
https://wpt.live/css/css-sizing/stretch/stretch-inline-size-003.html

Each piece of those tests has an abspos element whose in-flow parent is distinct from its abspos containing block. The trouble arises from cases where the in-flow parent is 0x0 due to writing-mode differences between it and its parent; this creates a situation where stretch should trivially resolve to 0, which isn't too interesting. (The test expects it to resolve to something nonzero right now, but that's because it's accidentally depending on a Firefox bug -- bug 1940321, I think -- which is how we manage to pass the test right now, with its incorrect expectations.)

Let's rescue these two tests so that none of these elements are inadvertently 0x0, so that stretch can reliably actually stretch to a nonzero size on the abspos child.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1940367: Fix some edge cases in WPTs stretch-block-size-003.html and stretch-inline-size-003.html. r?#layout

As noted in the bug report, I recently added these tests, but they turned out
to fail in Chrome because they were inadvertently depending on a Firefox bug
(specifically https://bugzilla.mozilla.org/show_bug.cgi?id=1940321 ).

This patch removes that inadvertent dependency, which makes them pass in Chrome.

This change does introduce some new test failures in Firefox, which appear to
be cases where we're over-counting the border/padding on the abspos element;
I'll investigate and address those failures in a followup, but for now I'm
aiming to make the test's expectations correct.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa002a402ee1
Fix some edge cases in WPTs stretch-block-size-003.html and stretch-inline-size-003.html. r=layout-reviewers,emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49980 for changes under testing/web-platform/tests

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fa002a402ee1

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot