194043 - Refactor exception logic between IDispatch and XPConnect

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[David Bradley]

This was mentioned in bug 183223. But wanted to call it out as a separate task
now. jst pointed out that the IDispatch exception logic in the IDispatch
wrapping of JSObjects is pretty a copy of what's in the XPConnect XPCOM wrapping
of JSObjects. So this should be factored out into separate function(s) that can
be called by both parties.

Comment 1

[David Bradley]

Attachment: Refactors the exceptions logic

Refactors the exception logic so that it can be shared between the IDispatch
code and existing XPConnect code.

Comment 2

[David Bradley]

Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic

I tried to preserve all the existing paths. That's something to really
scrutinize.

Comment 3

[Adam Lock]

Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic

r=adamlock

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic

Very nice! sr=jst

Comment 5

[David Bradley]

Patch checked in

Comment 6

[Phil Schwartau]

Checkin verified -