Closed
Bug 194043
Opened 22 years ago
Closed 22 years ago
Refactor exception logic between IDispatch and XPConnect
Categories
(Core :: XPConnect, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.4alpha
People
(Reporter: dbradley, Assigned: dbradley)
References
Details
Attachments
(1 file)
|
19.70 KB,
patch
|
adamlock
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
This was mentioned in bug 183223. But wanted to call it out as a separate task
now. jst pointed out that the IDispatch exception logic in the IDispatch
wrapping of JSObjects is pretty a copy of what's in the XPConnect XPCOM wrapping
of JSObjects. So this should be factored out into separate function(s) that can
be called by both parties.
|
Assignee | |
Updated•22 years ago
|
Target Milestone: --- → mozilla1.4alpha
|
|
Assignee | |
Comment 1•22 years ago
|
||
Refactors the exception logic so that it can be shared between the IDispatch
code and existing XPConnect code.
|
|
Assignee | |
Comment 2•22 years ago
|
||
Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic
I tried to preserve all the existing paths. That's something to really
scrutinize.
Attachment #116580 -
Flags: superreview?(jst)
Attachment #116580 -
Flags: review?(adamlock)
Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic
r=adamlock
Attachment #116580 -
Flags: review?(adamlock) → review+
|
||
Comment 4•22 years ago
|
||
Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic
Very nice! sr=jst
Attachment #116580 -
Flags: superreview?(jst) → superreview+
|
|
Assignee | |
Comment 5•22 years ago
|
||
Patch checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•