Refactor exception logic between IDispatch and XPConnect

VERIFIED FIXED in mozilla1.4alpha

Status

()

defect
VERIFIED FIXED
17 years ago
11 years ago

People

(Reporter: dbradley, Assigned: dbradley)

Tracking

Trunk
mozilla1.4alpha
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

This was mentioned in bug 183223. But wanted to call it out as a separate task
now. jst pointed out that the IDispatch exception logic in the IDispatch
wrapping of JSObjects is pretty a copy of what's in the XPConnect XPCOM wrapping
of JSObjects. So this should be factored out into separate function(s) that can
be called by both parties.
Target Milestone: --- → mozilla1.4alpha
Refactors the exception logic so that it can be shared between the IDispatch
code and existing XPConnect code.
Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic

I tried to preserve all the existing paths. That's something to really
scrutinize.
Attachment #116580 - Flags: superreview?(jst)
Attachment #116580 - Flags: review?(adamlock)
Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic

r=adamlock
Attachment #116580 - Flags: review?(adamlock) → review+
Comment on attachment 116580 [details] [diff] [review]
Refactors the exceptions logic

Very nice! sr=jst
Attachment #116580 - Flags: superreview?(jst) → superreview+
Patch checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Checkin verified -
Status: RESOLVED → VERIFIED
Depends on: 287107
You need to log in before you can comment on or make changes to this bug.