1940588 - MboxMsgOutputStream isn't threadsafe

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[Ben Campbell]

Following on from Bug 1931863.
MboxMsgOutputStream is a blocking stream and so could be potentially be called from other threads (eg the STS thread, when adapting the stream for async writing).
So all the public methods need to be threadsafe.

The note in the nsIOutputStream IDL only talks about protecting the refcount, but I think it all needs to be threadsafe.
https://searchfox.org/comm-central/source/mozilla/xpcom/io/nsIOutputStream.idl#48

Comment 1

[Ben Campbell]

Attachment: Bug 1940588 - Make MboxMsgOutputStream threadsafe. r=#thunderbird-back-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e1ed22af0b3c
Make MboxMsgOutputStream threadsafe. r=mkmelin

Comment 3

[Ben Campbell]

Attachment: Bug 1940588 - Comment tweak on MboxMsgOutputStream locking. r=#thunderbird-back-end-reviewers

Comment 4

[Kai Engert [:KaiE:]]

reopen to land the comment tweak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8a6d75aee0b
Comment tweak on MboxMsgOutputStream locking. r=kaie