Closed Bug 1940745 Opened 1 year ago Closed 11 months ago

Reopening a closed tab group with Ctrl+Shift+T doesn't work, if Ctrl+Shift+T was pressed while another window was focused first

Categories

(Firefox :: Session Restore, defect, P3)

Product:
Firefox
Component:
Session Restore
Type:
defect
Points:
3

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: jswinarton, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-tabgrps-sessionstore])

Steps to reproduce:

  1. Open two windows.
  2. In window A, create a tab group that has at least one tab with "real content" (i.e. not about:blank)
  3. Right click the tab group label and select "Delete tab group"
  4. Switch to window B and press Cmd+Shift+T
  5. Switch back to window A and press Cmd+Shift+T again

Expected result:
The tab group reopens.

Actual result:
The tabs reopen ungrouped

Additional context:
On step 4, pressing Cmd+Shift+T in window B, the following console error appears: JavaScript error: resource:///modules/sessionstore/SessionStore.sys.mjs, line 7888: NS_ERROR_ILLEGAL_VALUE: No saved tab group with specified id.

Blocks: 1907100
Severity: -- → S4
Points: --- → 3
Priority: -- → P3
Whiteboard: [fidefe-tabgrps]
Whiteboard: [fidefe-tabgrps] → [fidefe-tabgrps-sessionstore]

This seems to be working as expected for me. Jeremy, could you please confirm?

Flags: needinfo?(jswinarton)

:dao, you are right, I can no longer reproduce this. I am not sure which patch exactly fixed this, but I'm glad to know it's working!

Status: NEW → RESOLVED
Closed: 11 months ago
Flags: needinfo?(jswinarton)
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.