1940857 - Perma linting rust vendor - Errors occured; new rust crates were not vendored.

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

This happened when landing bug 1924961 the first time, but I tweaked the vendor lint to stay on 1.83 to have this handled separately.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1940857 - Prevent running `mach vendor rust` with cargo < 1.84.

And refresh the vendored crates with cargo 1.84.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1940857 - Make cargo aware of our MSRV.

without a rust-version somewhere, cargo thinks it can just bump
everything it can, and bumps the Cargo.lock version to 4 when vendoring
new crates, which doesn't work with our MSRV.

As far as experimentation goes, it doesn't seem we need rust-version set
in all our root crates.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a83e990dad51
Make cargo aware of our MSRV. r=firefox-build-system-reviewers,sergesanspaille
https://hg.mozilla.org/integration/autoland/rev/e4280732cdc2
Prevent running `mach vendor rust` with cargo < 1.84. r=firefox-build-system-reviewers,sergesanspaille

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fad3529d7fa
Fix rust vendor lint failure. CLOSED TREE

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a83e990dad51
https://hg.mozilla.org/mozilla-central/rev/e4280732cdc2
https://hg.mozilla.org/mozilla-central/rev/0fad3529d7fa