Closed Bug 1940968 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 50024 - Fix Trusted Type sink test changes from https://github.com/WebKit/Web…

Categories

(Core :: DOM: Security, task, P4)

Product:
Core
Component:
DOM: Security
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 2 open bugs,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50024 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50024
Details from upstream follow.

Frédéric Wang <fwang@igalia.com> wrote:

Fix Trusted Type sink test changes from https://github.com/WebKit/Web…

…Kit/pull/28165

  • trusted-types-duplicate-names-without-enforcement.html: this test is about createPolicy(), it actually never executes the default policy so we cannot check the sink value.

  • worker-constructor.https.html: This checks a sink value, conditioning the expectations on the input string but that one is always a URL. Fix that by actually saving the seen parameters and testing them in the promise tests.

Component: web-platform-tests → DOM: Security
Product: Testing → Core
Blocks: 1939805
Blocks: 1901492

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 10 subtests

Status Summary

Firefox

OK : 1[GitHub] 2[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
PASS : 29
FAIL : 8[GitHub] 10[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
ERROR: 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 2[GitHub]

Chrome

OK : 3
PASS : 37
FAIL : 2

Safari

OK : 1
FAIL : 8
ERROR: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /trusted-types/block-string-assignment-to-DOMWindowTimers-setTimeout-setInterval.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • Window.setTimeout assigned via policy (successful Script transformation).: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • Window.setTimeout(string) throws.: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • Window.setTimeout(null) throws.: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • Window.setInterval assigned via policy (successful Script transformation).: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • Window.setInterval(string) throws.: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • Window.setInterval(null) throws.: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • DedicatedWorkerGlobalScope.setTimeout(string) throws.: FAIL (Chrome: PASS)
    • DedicatedWorkerGlobalScope.setTimeout(null) throws.: FAIL (Chrome: PASS)
    • DedicatedWorkerGlobalScope.setInterval(string) throws.: FAIL (Chrome: PASS)
    • DedicatedWorkerGlobalScope.setInterval(null) throws.: FAIL (Chrome: PASS)
    • SharedWorkerGlobalScope.setTimeout(string) throws.: FAIL (Chrome: PASS)
    • SharedWorkerGlobalScope.setTimeout(null) throws.: FAIL (Chrome: PASS)
    • SharedWorkerGlobalScope.setInterval(string) throws.: FAIL (Chrome: PASS)
    • SharedWorkerGlobalScope.setInterval(null) throws.: FAIL (Chrome: PASS)
  • /trusted-types/trusted-types-duplicate-names-without-enforcement.html [wpt.fyi]
    • createPolicy - duplicate policies are allowed when Trusted Types are not enforced.: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
    • createPolicy - duplicate "default" policy is never allowed.: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • /trusted-types/worker-constructor.https.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: ERROR)
    • Block ServiceWorker creation via String: FAIL (Chrome: PASS)
    • Create ServiceWorker via string with default policy.: FAIL (Chrome: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7bd5bcd55d81 [wpt PR 50024] - Fix Trusted Type sink test changes from https://github.com/WebKit/Web…, a=testonly

https://hg.mozilla.org/mozilla-central/rev/7bd5bcd55d81

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Blocks: 1942306
You need to log in before you can comment on or make changes to this bug.