Closed Bug 1940991 Opened 1 year ago Closed 1 year ago

2.6 - 2.42% Base Content JS / Base Content JS + 1 more (Linux, OSX, Windows) regression on Tue January 7 2025

Categories

(Core :: JavaScript: GC, defect)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox136 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a awsy performance regression from push d95fadc5b8ff50c770be155a699c1c0aa8050925. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
3% Base Content JS windows11-64-2009-shippable-qr fission 1,533,224.00 -> 1,573,043.33
2% Base Content JS macosx1470-64-shippable fission 1,530,770.00 -> 1,568,909.33
2% Base Content JS linux1804-64-shippable-qr fission 1,530,306.00 -> 1,567,409.67

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
16% Heap Unclassified windows11-64-2009-shippable-qr fission tp6 116,071,111.11 -> 97,089,706.46
12% Heap Unclassified macosx1470-64-shippable fission tp6 158,382,534.10 -> 138,791,671.19
10% Heap Unclassified macosx1470-64-shippable fission tp6 156,619,282.26 -> 140,786,002.61

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 43268

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to fbilt@mozilla.com.

Flags: needinfo?(jcoppeard)

This is partly due to the way Base Content JS is measured. Local tests show that the increase is due to unused space in arenas allocated to hold small buffers following bug 1934856. Previously these were allocated using jemalloc. However allocated but unused space owned by jemalloc is not included in this measurement. So this does not represent an increase in allocated memory overall.

Regardless, this change is mostly mitigated by bug 1940066.

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(jcoppeard)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.