1940998 - network overrides state leaks across toolboxes

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Julian Descottes [:jdescottes]]

STRs:

• set script override on a file
• close and reopen toolbox

ER:
Override should no longer be applied, purple dot should not be displayed in the debugger.

AR:
Override is not applied but the debugger is still showing the purple icon

This is because:

• devtools/client/framework/reducers/network-overrides.js creates initialReducerState as a singleton shared by all toolboxes
• we directly mutate mutableOverrides when updating the state

It was intended to make the state mutable here, but we should get rid of the initialReducerState which leads to unintentionally leaking the overrides across toolboxes.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1940998 - [devtools] Use more specific classname for script override icon in debugger

The current classname "override" is generic and hard to grep.
This will allow to use it in tests a bit more sanely

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1940998 - [devtools] Do not update the initial state for the network overrides reducer

Depends on D233897

Modules such as devtools/client/framework/reducers/network-overrides.js are only
loaded once, making the initial state a singleton.

If we mutate this, it will therefore apply to all toolboxes until the browser is
closed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e57cb85ece9e
[devtools] Use more specific classname for script override icon in debugger r=devtools-reviewers,bomsy
https://hg.mozilla.org/integration/autoland/rev/4c700f28e869
[devtools] Do not update the initial state for the network overrides reducer r=devtools-reviewers,nchevobbe

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e57cb85ece9e
https://hg.mozilla.org/mozilla-central/rev/4c700f28e869