1941030 - pdfjs.enableScripting does not exist on all Android browsers

Status: VERIFIED FIXED

(GeckoView :: PDF Viewer, defect, P1)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: pdftris.pdf

Steps to reproduce

1. Open the attached PDF on any of the Android browsers.
2. Attempt to play the tetris game by clicking the 'Start game' button.

Expected results

• PDF scripting is enabled and the game continues as expected, similar to desktop.

Actual results

• Clicking the button does nothing.
• The pref in about:config to allow this (pdfjs.enableScripting) is not there.

Additional information

• Device: Pixel 8a
• Browsers tested: Focus, Fenix, Reference Browser with 136, 135, and 134.
• calixte investigated this a bit over Slack:

  if I create manually the pref pdfjs.enableScripting and set it to true then it works as expected
  it used here: https://searchfox.org/mozilla-central/rev/29e186485fe1b835f05bde01f650e371545de98e/browser/installer/package-manifest.in#244-247 [updated to a permalink].
  I tested scripting a while back and it worked so it's a regression

Comment 1

[Calixte Denizet (:calixte)]

I wonder if the regressor could be the bug 1940155.
There are only few use of JS_PREFERENCE_PP_FILES:
https://searchfox.org/mozilla-central/search?q=JS_PREFERENCE_PP_FILES&path=&case=false&regexp=false
so I wonder if it's correct for Android.
:nalexander, what do you think ?

Comment 2

[Calixte Denizet (:calixte)]

A try:
https://treeherder.mozilla.org/jobs?repo=try&revision=ad7f203979afd1995212a26b3349b2eea1ab6552

Comment 3

[Calixte Denizet (:calixte)]

Attachment: Bug 1941030 - Add the pdfjs prefs file to omni.ja when building for Android r=#geckoview-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7613d0e977a
Add the pdfjs prefs file to omni.ja when building for Android r=geckoview-reviewers,nalexander,calu

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d7613d0e977a

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Calixte Denizet (:calixte)]

Attachment: Bug 1941030 - Add the pdfjs prefs file to omni.ja when building for Android r=#geckoview-reviewers

Original Revision: https://phabricator.services.mozilla.com/D233982

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Android users aren't able to fill pdf forms containing embedded JS
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Open the pdf in comment #0
• Risk associated with taking this patch: low
• Explanation of risk level: it's just a matter of embedding a pref file in omni.ja
• String changes made/needed: no
• Is Android affected?: yes

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b08ff658e79

Comment 10

[Calixte Denizet (:calixte)]

Attachment: Bug 1941030 - Add the pdfjs prefs file to omni.ja when building for Android r=#geckoview-reviewers

Original Revision: https://phabricator.services.mozilla.com/D233982

Comment 11

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Android users aren't able to fill pdf forms containing embedded JS
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Open the pdf in comment #0
• Risk associated with taking this patch: low
• Explanation of risk level: it's just a matter of embedding a pref file in omni.ja
• String changes made/needed: no
• Is Android affected?: yes

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/25587bae0323

Comment 13

[Lorand Janos]

Verified as fixed on the latest builds:

• latest Nightly 136.0a1 from 2025-01-21;
• latest Beta 135.0b7;
• latest RC (134.0.2).

The pdf file can be opened, the game can be played on each build.

Devices used:

• Google Pixel 9 Pro XL (Android 15);
• Lenovo TB X606X (Android 10).

Marking the ticket as verified on 134, 135 and 136.