1941096 - Remove newline around U+FF5E instead of replacing it with space in Japanese/Chinese documents

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Tatsunori Uchino]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

https://codepen.io/tats-u/pen/GgKxpyE

Actual results:

Extra spaces around the first ～ (U+FF5E) in the first line

Expected results:

The 2 line has the same visual

About FF5E:

https://www.compart.com/en/unicode/U+FF5E
https://github.com/prettier/prettier/pull/16832

• East Asian Width: F
• Category: Sm

Fix:

https://github.com/mozilla/gecko-dev/blob/29e186485fe1b835f05bde01f650e371545de98e/intl/unicharutil/util/nsUnicharUtils.cpp#L524-L525

 bool IsEastAsianPunctuation(uint32_t u) {
   return intl::UnicodeProperties::IsEastAsianWidthFHW(u) &&
-         intl::UnicodeProperties::IsPunctuation(u);
+         (intl::UnicodeProperties::IsPunctuation(u) || u == 0xff5e);
 }

Comment 1

[Daniel Holbert [:dholbert]]

Thanks for the report & the suggested patch!

I'm hoping this is in jfkthame's wheelhouse, given that he worked on similar bug 1935148.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1941096 - Treat FULLWIDTH TILDE as CJK punctuation for segment break transformation purposes. r=#layout

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a55665fe1fc2
Treat FULLWIDTH TILDE as CJK punctuation for segment break transformation purposes. r=dshin

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50388 for changes under testing/web-platform/tests

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a55665fe1fc2

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot