1941161 - Add a `quick-suggest-deletion-request` ping

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

With bug 1940808 implemented, we'll probably need to add a quick-suggest-deletion-request ping, although I'm not 100% sure. I talked with chutten about it and he thinks so, but due to its business-critical nature I'm not so sure. Splitting this out into its own bug separate from bug 1940808 should help us discuss it as its own issue. I have a WIP patch for it and it's pretty small, so the actual changes required aren't much.

Bug 1932643 is an example of adding a deletion-request ping.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1941161 - Add a `quick-suggest-deletion-request` ping.

This builds on D233752 and D233980 and submits a deletion-request ping when
either Suggest is disabled or the user disables both sponsored and non-sponsored
Suggest suggestions. This means that if the user clicks some sponsored
suggestions but then disables all Suggest suggestions, we'll send a deletion
request, and presumably if the request happens soon enough after the clicks, we
won't get credit for those clicks, depending on how our data pipeline handles
that. My understanding is that a deletion-request ping is pretty much required
for pings with follows_collection_enabled: false.

context_id is sent in this new ping just like the quick-suggest ping.

Depends on D233752

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64a3076e265c
Add a `quick-suggest-deletion-request` ping. r=daisuke,TravisLong,nanj

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/64a3076e265c

Comment 4

[Arkadiusz Komarzewski [:akomar]]

:adw was the expectation here that when quick-suggest-deletion-request is received, quick-suggest pings with matching context_id should be deleted from the warehouse?
I'd expect this to be the case, and we would need to wire up these pings in Shredder config for that.

Comment 5

[Drew Willcoxon :adw]

Yes please, thanks for asking! I should have reached out, so I appreciate it. Could you link me to a PR/bug when there is one, just so I can follow along?