Closed Bug 1941184 Opened 9 months ago Closed 9 months ago

Perma browser/components/sidebar/tests/browser/browser_sidebar_collapsed_close_tab_button.js | The inactive tab is not showing the close button. - Got "1", expected "0" when Gecko 136 merges to beta on 2025-02-03

Categories

(Firefox :: Sidebar, defect, P1)

Product:
Firefox
Component:
Sidebar
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 + verified

People

(Reporter: smolnar, Assigned: jsudiaman)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-sidebar])

Attachments

(1 file)

Bug 1941184 - Fix browser_sidebar_collapsed_close_tab_button.js failures caused by close button appearing on mouse hover. r?#sidebar-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Central as beta simulation

How to run these simulations

Failure log

TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_collapsed_close_tab_button.js | The active tab is showing the close button. - 
[task 2025-01-12T10:38:25.141Z] 10:38:25     INFO - Buffered messages finished
[task 2025-01-12T10:38:25.141Z] 10:38:25     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_sidebar_collapsed_close_tab_button.js | The inactive tab is not showing the close button. - Got "1", expected "0"
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - Stack trace:
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - chrome://mochikit/content/browser-test.js:test_is:1627
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_sidebar_collapsed_close_tab_button.js:test_toggle_collapse_close_button:43
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-01-12T10:38:25.142Z] 10:38:25     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_sidebar_collapsed_close_tab_button.js | The inactive tab is showing the close button on hover.
Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Whiteboard: [fidefe-sidebar]
Assignee: kcochrane → jsudiaman

:jsudiaman next week is the final week of nightly for Fx136 before it goes to beta.
Hopefully there are no concerns with fixing this by the end of next week?

Flags: needinfo?(jsudiaman)

Patch is working in latest beta-simulation

Flags: needinfo?(jsudiaman)
Pushed by jsudiaman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/296cd2da5c5f Fix browser_sidebar_collapsed_close_tab_button.js failures caused by close button appearing on mouse hover. r=sidebar-reviewers,kcochrane
Severity: -- → N/A
Priority: -- → P1
Type: task → defect

https://hg.mozilla.org/mozilla-central/rev/296cd2da5c5f

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox136: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

Verified fixed in today's central as beta simulation

Status: RESOLVED → VERIFIED
status-firefox136: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: