194140 - [QT] Menu hold back events

Status: VERIFIED FIXED

(Core Graveyard :: Ports: Qt, defect)

Description

[Alexander Opitz]

QTMenu is Modal, but shouldn't.

Comment 1

[Alexander Opitz]

Attachment: widget/src/qt/nsQWidget.cpp

Comment 2

[Alexander Opitz]

Attachment: widget/src/qt/nsWindow.cpp

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 114995 [details] [diff] [review]
widget/src/qt/nsQWidget.cpp

Marking this review- because you should not just comment out a line in the
source code without explaining why it is still there.
Either add a comment why it's there, or remove the line and the case: label
altogether.

That said - why should popup windows not have the popup window type?

Comment 4

[Alexander Opitz]

Excuse ... the line can be removed, cause The QT PopUp flag makes the widget
modal but that's not what we want. Will make a new patch at home.

Comment 5

[Alexander Opitz]

Attachment: widget/src/qt/nsQWidget.cpp

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

     case eWindowType_popup:
-      w |= Qt::WType_Popup;
       break;

Hm, why do you need to keep the empty case label? Is there a default: label that
you don't want to happen?

Comment 7

[Alexander Opitz]

We have no default ... so I case it to prevent a build warning. We can also 
remove this and the 2 lines down and add for this a default: 
 
If it's better, I'll do this. 

Comment 8

[timeless]

ok, the pair works nicely. r=me. from build warnings it isn't uncommon for the
qt port not to have default cases, i could go either way.

Comment 9

[Robert Kaiser]

On QT_REBIRTH_20030222_BRANCH:

Checking in nsWindow.cpp;
/cvsroot/mozilla/widget/src/qt/Attic/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 1.15.10.1; previous revision: 1.15
done
Checking in nsQWidget.cpp;
/cvsroot/mozilla/widget/src/qt/Attic/nsQWidget.cpp,v  <--  nsQWidget.cpp
new revision: 1.7.10.1; previous revision: 1.7
done

I checked the patches in for [e-mail], fixed.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

well, menus work now and look fine, so I guess I can verify this fix. (latest
cvs branch build, Qt 3.1.1, debian unstable)