1941579 - [wpt-sync] Sync PR 50070 - Fix assert in WPT h265-level-id.https.html

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 50070 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50070
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

Fix assert in WPT h265-level-id.https.html

In preparation for a WebRTC level fix that will make these tests pass,
replace some assert_equals() lines that incorrectly does a reference
comparison when a value comparison is the right thing to do.

RTCCodec is passed by value i.e. the JS object returned by
getParameters(). Instead we should value compare the mimeType and
sdpFmtpLine strings.

Bug: chromium:381407888
Change-Id: Iaa2deff981338bfa86670a3f99241af60ebf845e
Reviewed-on: https://chromium-review.googlesource.com/6170449
WPT-Export-Revision: d513b7ee1e6f364d54ea4a0111906a6d4fcf5134

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=77a13388ba5a29e70a9256a64bb189d64f6f4eb1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 3 subtests

Status Summary

Firefox

OK : 1
PRECONDITION_FAILED: 3

Chrome

OK : 1
PRECONDITION_FAILED: 3

Safari

OK : 1
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc/protocol/h265-level-id.https.html [wpt.fyi]
  • Offer to send H265, answer to receive level-id=30 results in level-id=30: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
  • Offer to receive level-id=30 and set codec from getParameters: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)
  • Offer to receive level-id=30 and set codec from getCapabilities: PRECONDITION_FAILED (Chrome: PRECONDITION_FAILED, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e14398295fb
[wpt PR 50070] - Fix assert in WPT h265-level-id.https.html, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0e14398295fb