1941609 - [Fenix PDF] Revert behaviour to make PDFs from Fenix downloads open in Fenix

Status: VERIFIED FIXED

(Fenix :: General, task, P1)

Comment 1

[Nicholas Poon [:Nick]]

Attachment: Bug 1941609 - Always allow users to choose how to open local Fenix PDFs

Revert the PDF behaviour change in D225118 and also fix the tests by reverting D227498

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44c3bc37709f
Always allow users to choose how to open local Fenix PDFs r=android-reviewers,007

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/44c3bc37709f

Comment 4

[Nicholas Poon [:Nick]]

Comment on attachment 9459763 [details]
Bug 1941609 - Always allow users to choose how to open local Fenix PDFs

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: A lot of users are unhappy with the PDF viewer experience when opening local PDFs. This is one of our biggest differentiators from other browsers. This fix allows us to revert the previous change and do some more investigation and make changes before landing the change again
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Fenix:
• Download a PDF and verify that opening it from fenix will open in their default PDF app / prompt the user to choose where to open it from. Specifically, we should test the open in the download complete bottom sheet, download notification, and menu > downloads.
  Focus:
• Download a PDF and verify that opening it from fenix behaves the same and isn't broken. Specifically, we should test the open in the download complete snackbar and download notification
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is covered by automated testing and I have already tested it locally also
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Fun question - this patch doesn't graft cleanly to Beta due to conflicts with the changelog change. Seems easy enough to resolve by putting it into the 135 section, but presumably we'd want to land a similar change on central to reflect this change riding in 135 also?

Comment 6

[Nicholas Poon [:Nick]]

Yes, we definitely want the change in both beta and central (nightly). I think we can move the changelog message to 135 though - it makes sense that if the change was made in 135, that it would carry to 136 also. Thanks Ryan - I will request backout for the patch and make the change

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9459763 [details]
Bug 1941609 - Always allow users to choose how to open local Fenix PDFs

Approved for 135.0b7.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/aab52625ccb1

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eaca4912946f
Follow-up: Move changelog entry to 135. r=npoon

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/eaca4912946f

Comment 11

[Vasilica Tamas QA [:vtamas]]

Attachment: PdfPrompt.JPEG

This issue is verified as fixed on Firefox Nightly 136 (2025-01-21), Focus Nightly 136 (2025-01-21), Firefox 135 beta 7 and Focus 135 beta 7 using Samsung Galaxy S24 Ultra (Android 14), Google Pixel 9 Pro (Android 14) and Lenovo Yoga Tab 11 (Android 12). Confirming that the user is prompted to select an app in order to open the downloaded PDF file.