1941681 - Scripts from distinct content scripts are mixed in the debugger source tree and confuse

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1413872 introduced an issue with the following code:
https://searchfox.org/mozilla-central/rev/eb80f267aabbf90ac66ebbed77b6d33592eb2be0/devtools/server/actors/targets/content-script.js#54

It will accept any future global after the content script is instantiated, leading the confusing duplicated scripts in the source tree, as well as confusing stepping.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1413872

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1941681 - [devtools] Only track content script sandbox global from the Content Script Targets.

This prevents debugging any global created after the content script target is initialized.
(possibly any other content script sandbox or same-process iframes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51cb63ab8f1e
[devtools] Only track content script sandbox global from the Content Script Targets. r=devtools-reviewers,nchevobbe

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/51cb63ab8f1e

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 9459925 [details]
Bug 1941681 - [devtools] Only track content script sandbox global from the Content Script Targets.

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: The debugger goes completely off with duplicated scripts and duplicated steps when hitting a breakpoint and stepping.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: * Install Violentmonkey https://addons.mozilla.org/firefox/addon/violentmonkey
• Install the userscript https://gist.github.com/deevroman/9a3ed7768766baf74347bef3545e6f33/raw/96ac306cba3a69169df1dd2e717584403227c68b/bug.user.js
• Open a debugger
• Open https://www.openstreetmap.org
• the debugger will pause, step forward

The debugger should step on the next line and within the same file.
Without this patch it will step on the same line, but a buggy duplicated source.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is fixing an obvious mistake and is a single line change.
• String changes made/needed:
• Is Android affected?: Yes

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9459925 [details]
Bug 1941681 - [devtools] Only track content script sandbox global from the Content Script Targets.

Approved for 135.0b8.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/99538629f2e1

Comment 8

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (136.0a1/20250122165122) and Beta (135.0b8/20250122091721) under Windows 10 x64 and Ubuntu 24.04 LTS.

The debugger will now properly step on the next line within the same file and will no longer step on the same line from within a duplicated source.