1941692 - Clean up the browser_telemetry_other.js Suggest test

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

After we removed legacy Suggest telemetry events in bug 1921748, browser_telemetry_other.js only tests TelemetryEnvironment now. I'd like to rename it and clean it up a little.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1941692 - Rename and clean up the browser_telemetry_other.js Suggest test.

This renames browser_telemetry_other.js to browser_telemetry_environment.js
since it only tests TelemetryEnvironment now.

A few tasks do the same thing (with different pref values), so I also factored
that out into a doToggleTest() helper.

Also, there are some chunks in this test that don't actually do anything
anymore, so I've removed them. Those chunks were modified in bug 1921748 due to
removal of some legacy telemetry events, and we should have removed them then
but it was my fault for not realizing that.

Depends on D234257

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b983147bba3
Rename and clean up the browser_telemetry_other.js Suggest test. r=daisuke

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5b983147bba3