Closed Bug 1941752 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 50096 - CSS shape() - fix canonical representation expectations for curve/smooth

Categories

(Core :: Layout: Floats, task, P4)

Product:
Core
Component:
Layout: Floats
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50096 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50096
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

CSS shape() - fix canonical representation expectations for curve/smooth

Canonical representations should generally omit defaults.
The tests were adding the default from {start|origin} superfluously,
due to the WebKit implementation.

The chromium implementation already does the right thing, so changing
the expectations and removing the expectations files.

Bug: 389713716
Change-Id: I00f44b9e566f8cb61d99e8e95a3ef5e395899656
Reviewed-on: https://chromium-review.googlesource.com/6172338
WPT-Export-Revision: 6c0f6adb8b3c98136d979ad919e35f2e7acaa9a0

Component: web-platform-tests → Layout: Floats
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests and 52 subtests

Status Summary

Firefox

OK : 2
PASS: 48
FAIL: 34

Chrome

OK : 2
PASS: 3
FAIL: 79

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-shapes/shape-functions/shape-function-computed.tentative.html [wpt.fyi]
    • Property clip-path value 'shape(from 20px 40px, curve by 20px 20px with 10px 30px)': FAIL (Chrome: FAIL)
    • Property clip-path value 'shape(from 20px 40px, curve by 20px 20px with 10px 30px / 12px 32px)': FAIL (Chrome: FAIL)
    • Property clip-path value 'shape(from center, curve to center bottom with top right / bottom right)': FAIL (Chrome: FAIL)
    • Property clip-path value 'shape(from center, curve by 20px 20px with 10px 30px from end / 12px 32px from start)': FAIL (Chrome: FAIL)
    • Property clip-path value 'shape(from center right, curve by 20px 20px with 10px 30px from origin / 12px 32px from origin)': FAIL (Chrome: FAIL)
    • Property clip-path value 'shape(from 20px 40px, curve to top right with 10px 30px from origin / 12px 32px from origin)': FAIL (Chrome: FAIL)
    • Property clip-path value 'shape(from 20px 40px, smooth by 20px 20px with 12px 32px)': FAIL (Chrome: FAIL)
  • /css/css-shapes/shape-functions/shape-function-valid.tentative.html [wpt.fyi]
    • e.style['clip-path'] = "shape(from 20px 40px, move to 20px 30px, hline to left, hline to center, hline to right)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, move to 20px 30px, hline to x-start, hline to y-start)" should set the property value: FAIL
    • e.style['clip-path'] = "shape(from 20px 40px, move to 20px 30px, vline to top, vline to center, vline to bottom)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, move to 20px 30px, vline to y-start, vline to y-end)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to 20px 20px with 10px 30px)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to 20em 20pt with 10vw 30vh)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to 10% 20% with 10px 30px / 12px 32px)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to top left with 10px 30px / 12px 32px)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20% 40%, curve to center with center right / bottom center)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from bottom right, curve to left with center right / bottom center)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to bottom left with 10px 30px from end)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to right center with 10px 30px from start / 12px 32px from end)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to right center with 10px 30px from start/12px 32px from end)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to right center with 10px 30px from end / 12px 32px from origin)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve to right center with 10px 30px from origin / 12px 32px from start)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve by 20px 20px with 10px 30px)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve by 20px 20px with 10px 30px from origin)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve by 20px 20px with 10px 30px / 12px 32px)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve by 20% 20em with 10px 30px from start / 12px 32px from end)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, curve by 20% 20em with 10.3% 30px from origin / 12pt 5.4% from start)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from top left, smooth to top right)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, smooth to center 20%)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from right bottom, smooth by 20px 20px with 12px 32px)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, smooth by 20pt 20px with 12px 32px from start)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from center 40px, smooth by 20% 20% with 12px 32px from end)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from center, smooth by 20px 20px with 12px 32px from origin)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, arc to top right of 10%)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['clip-path'] = "shape(from 20px 40px, move to 20px 30px, hline to x-start, vline to y-start)" should set the property value: FAIL (Chrome: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8040be026908 [wpt PR 50096] - CSS shape() - fix canonical representation expectations for curve/smooth, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8040be026908

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.