Closed Bug 1941813 Opened 1 year ago Closed 13 days ago

Include top-most frame of the stacktrace to all "log.entryAdded" events for Console API messages

Categories

(Remote Protocol :: WebDriver BiDi, task, P3)

task
Points:
3

Tracking

(firefox151 fixed)

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: whimboo, Assigned: Sasha)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [webdriver:m19])

Attachments

(1 file)

With the landed changes on https://github.com/w3c/webdriver-bidi/pull/854 we should always include the stack trace for Console API messages.

Tests will be downstream synced via bug 1942564.

Depends on: 1942564

As a first step we could just try to only include the top-most frame of the stack, that we could extract more easily. Later on we could include the full stack once it's clear how much performance it will cost.

Lets also file new bug for adding the full stack

Points: --- → 3
Flags: needinfo?(hskupin)
Priority: -- → P2
Whiteboard: [webdriver:blocked] → [webdriver:m15]

Updating the summary to what we discussed last week. Also I filed bug 1944136 to include the full stack. For this bug we no longer need the work from bug 1744705.

No longer depends on: 1744705
Flags: needinfo?(hskupin)
Summary: "log.entryAdded" event should always include stacktrace for Console API messages → Include top-most frame of the stacktrace to all "log.entryAdded" events for Console API messages
Whiteboard: [webdriver:m15] → [webdriver:m16]
Whiteboard: [webdriver:m16] → [webdriver:m17]
Priority: P2 → P3
Whiteboard: [webdriver:m17] → [webdriver:m18]
Whiteboard: [webdriver:m18] → [webdriver:m19]
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Pushed by aborovova@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/670a267f3e3b https://hg.mozilla.org/integration/autoland/rev/a12fb2e96503 [webdriver-bidi] Include top-most frame of the stacktrace to all "log.entryAdded" events for Console API messages. r=whimboo
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: