Closed Bug 1941814 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 50100 - Remove tentative from dialog closedby attribute and requestClose

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50100 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50100
Details from upstream follow.

Luke Warlow <lwarlow@igalia.com> wrote:

Remove tentative from dialog closedby attribute and requestClose

Spec change merged at https://github.com/whatwg/html/pull/10737

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 4 tests and 56 subtests

Status Summary

Firefox

OK : 4
PASS: 22
FAIL: 98

Chrome

OK : 4
PASS: 88

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/interactive-elements/the-dialog-element/dialog-closedby.html [wpt.fyi]
    • closedby=any, Non-modal: FAIL (Chrome: PASS)
    • closedby=any, Modal: FAIL (Chrome: PASS)
    • closedby=closerequest, Non-modal: FAIL (Chrome: PASS)
    • closedby=closerequest, Modal: FAIL (Chrome: PASS)
    • closedby=none, Non-modal: FAIL (Chrome: PASS)
    • closedby=none, Modal: FAIL (Chrome: PASS)
    • closedby=AnY, Non-modal: FAIL (Chrome: PASS)
    • closedby=AnY, Modal: FAIL (Chrome: PASS)
    • closedby=ClOsErEqUeSt, Non-modal: FAIL (Chrome: PASS)
    • closedby=ClOsErEqUeSt, Modal: FAIL (Chrome: PASS)
    • closedby=NoNe, Non-modal: FAIL (Chrome: PASS)
    • closedby=NoNe, Modal: FAIL (Chrome: PASS)
    • closedby=invalid, Non-modal: FAIL (Chrome: PASS)
    • closedby=invalid, Modal: FAIL (Chrome: PASS)
    • closedby=, Non-modal: FAIL (Chrome: PASS)
    • closedby=, Modal: FAIL (Chrome: PASS)
    • closedby=null, Non-modal: FAIL (Chrome: PASS)
    • closedby=null, Modal: FAIL (Chrome: PASS)
  • /html/semantics/interactive-elements/the-dialog-element/dialog-popover-closedby-complex.html [wpt.fyi]
    • clicking outside all with modeless dialogA and modeless dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking popoverA with modeless dialogA and modeless dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking dialogA with modeless dialogA and modeless dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking outside all with modeless dialogA and modal dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking popoverA with modeless dialogA and modal dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking dialogA with modeless dialogA and modal dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking outside all with modal dialogA and modeless dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking popoverA with modal dialogA and modeless dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking dialogA with modal dialogA and modeless dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking outside all with modal dialogA and modal dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking popoverA with modal dialogA and modal dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking dialogA with modal dialogA and modal dialogB, normal DOM nesting: FAIL (Chrome: PASS)
    • clicking outside all with modeless dialogA and modeless dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking popoverA with modeless dialogA and modeless dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking dialogA with modeless dialogA and modeless dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking outside all with modeless dialogA and modal dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking popoverA with modeless dialogA and modal dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking dialogA with modeless dialogA and modal dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking outside all with modal dialogA and modeless dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking popoverA with modal dialogA and modeless dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking dialogA with modal dialogA and modeless dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking outside all with modal dialogA and modal dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking popoverA with modal dialogA and modal dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
    • clicking dialogA with modal dialogA and modal dialogB, same structure, but with shadow DOM slots: FAIL (Chrome: PASS)
  • /html/semantics/interactive-elements/the-dialog-element/dialog-requestclose.html [wpt.fyi]
    • requestClose basic behavior for modeless dialog with closedby=null: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modeless dialog with closedby=null: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modeless dialog with closedby=null: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modeless dialog with closedby=null: FAIL
    • requestClose avoids abuse prevention logic for modeless dialog with closedby=null: FAIL
    • requestClose(returnValue) passes along the return value for modeless dialog with closedby=null: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modeless dialog with closedby=null: FAIL
    • requestClose basic behavior for modeless dialog with closedby=any: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modeless dialog with closedby=any: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modeless dialog with closedby=any: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modeless dialog with closedby=any: FAIL
    • requestClose avoids abuse prevention logic for modeless dialog with closedby=any: FAIL
    • requestClose(returnValue) passes along the return value for modeless dialog with closedby=any: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modeless dialog with closedby=any: FAIL
    • requestClose basic behavior for modeless dialog with closedby=closedrequest: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modeless dialog with closedby=closedrequest: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modeless dialog with closedby=closedrequest: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modeless dialog with closedby=closedrequest: FAIL
    • requestClose avoids abuse prevention logic for modeless dialog with closedby=closedrequest: FAIL
    • requestClose(returnValue) passes along the return value for modeless dialog with closedby=closedrequest: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modeless dialog with closedby=closedrequest: FAIL
    • requestClose basic behavior for modeless dialog with closedby=none: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modeless dialog with closedby=none: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modeless dialog with closedby=none: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modeless dialog with closedby=none: FAIL
    • requestClose avoids abuse prevention logic for modeless dialog with closedby=none: FAIL
    • requestClose(returnValue) passes along the return value for modeless dialog with closedby=none: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modeless dialog with closedby=none: FAIL
    • requestClose basic behavior for modal dialog with closedby=null: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modal dialog with closedby=null: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modal dialog with closedby=null: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modal dialog with closedby=null: FAIL
    • requestClose avoids abuse prevention logic for modal dialog with closedby=null: FAIL
    • requestClose(returnValue) passes along the return value for modal dialog with closedby=null: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modal dialog with closedby=null: FAIL
    • requestClose basic behavior for modal dialog with closedby=any: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modal dialog with closedby=any: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modal dialog with closedby=any: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modal dialog with closedby=any: FAIL
    • requestClose avoids abuse prevention logic for modal dialog with closedby=any: FAIL
    • requestClose(returnValue) passes along the return value for modal dialog with closedby=any: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modal dialog with closedby=any: FAIL
    • requestClose basic behavior for modal dialog with closedby=closedrequest: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modal dialog with closedby=closedrequest: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modal dialog with closedby=closedrequest: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modal dialog with closedby=closedrequest: FAIL
    • requestClose avoids abuse prevention logic for modal dialog with closedby=closedrequest: FAIL
    • requestClose(returnValue) passes along the return value for modal dialog with closedby=closedrequest: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modal dialog with closedby=closedrequest: FAIL
    • requestClose basic behavior for modal dialog with closedby=none: FAIL (Chrome: PASS)
    • requestClose fires both cancel and close for modal dialog with closedby=none: FAIL (Chrome: PASS)
    • closedby has no effect on dialog.requestClose() for modal dialog with closedby=none: FAIL (Chrome: PASS)
    • requestClose can be cancelled for modal dialog with closedby=none: FAIL
    • requestClose avoids abuse prevention logic for modal dialog with closedby=none: FAIL
    • requestClose(returnValue) passes along the return value for modal dialog with closedby=none: FAIL
    • requestClose(returnValue) doesn't change returnvalue when cancelled for modal dialog with closedby=none: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc4f70c3e231 [wpt PR 50100] - Remove tentative from dialog closedby attribute and requestClose, a=testonly https://hg.mozilla.org/integration/autoland/rev/c155283fd898 [wpt PR 50100] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fc4f70c3e231
https://hg.mozilla.org/mozilla-central/rev/c155283fd898

Status: NEW → RESOLVED
Closed: 1 month ago
: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.